bors[bot]
2b39717cab
Merge #103
...
103: Dependency updates r=msfjarvis a=msfjarvis
bors r+
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 08:45:46 +00:00
8f53a39f63
build: upgrade kotlin
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 14:14:45 +05:30
020976e257
build: update remaining dependencies
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 14:14:44 +05:30
cdfa20b9a7
build: upgrade to Compose alpha11
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 14:14:43 +05:30
b87e242de2
build: remove gradle-versions-plugin
...
I use a Gradle init script for this now
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-08 13:13:02 +05:30
bors[bot]
147f2d23a5
Merge #101
...
101: Fix cache issues r=msfjarvis a=Skrilltrax
Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2021-02-05 10:38:39 +00:00
Aditya Wasan
0fcf584b01
src: make LobstersRepository a singleton
...
Earlier both LobstersViewModel and LobstersPagingSource were getting a different instance of LobstersRepository.
This lead to cache issues where LobstersPagingSource filled the cache but it was not available to the LobstersViewModel.
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-02-05 15:00:23 +05:30
bors[bot]
43361b3a2a
Merge #102
...
102: Gradle build improvements r=msfjarvis a=msfjarvis
- Cleans up unnecessary dependencies
- Skips configuring Dagger on modules where it's not needed
- Hacks together a way to load buildSrc plugin dependencies from Kotlin sources
bors r+
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-01 13:14:30 +00:00
df1db3d0ff
buildSrc: move plugin dependencies to Dependencies.kt
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-01 18:43:52 +05:30
2a4c58a680
buildSrc: conditionally configure Dagger and disable kapt in tests
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-01 18:32:47 +05:30
0c1b20d3e7
buildSrc: remove unneeded AGP builder dependencies
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-02-01 18:25:30 +05:30
Aditya Wasan
9ce33bba75
src: add isCacheReady to let users know cache status
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 23:02:16 +05:30
bors[bot]
23ec6ea9b1
Merge #75
...
75: Use SQLDelight instead of Room r=msfjarvis a=Skrilltrax
Deletes all the existing Room database code and replaces it with a simplified SQLDelight-backed implementation ready for Kotlin Multiplatform.
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 15:16:14 +00:00
Aditya Wasan
1946b1c333
build: remove ExperimentalStdlibApi compiler flag
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 19:13:58 +05:30
Aditya Wasan
1251ae3bc0
src: remove is_saved from LobstersPost and fix tests
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 18:49:49 +05:30
Aditya Wasan
6b3b35d4df
src: manually pass submitterJsonAdapter to SubmitterAdapter
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 18:22:23 +05:30
Aditya Wasan
9e943c82b9
src: add hilt and update hilt modules
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 17:51:21 +05:30
Aditya Wasan
9c4c0b1e56
src: use IconToggleButton and add crossfade animation
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 17:23:26 +05:30
Aditya Wasan
a5538ece8e
src: add filename to AndroidSqliteDriver
...
SQLDelight creates a in-memory DB if the file name is null.
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 16:31:20 +05:30
Aditya Wasan
092599d167
src: add isSaved parameter to LobstersItem
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 16:17:08 +05:30
Aditya Wasan
af72415952
build: remove kotlinReflect dependency
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 15:48:43 +05:30
Aditya Wasan
a2c058877a
src: add an in-memory map to cache db posts
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 15:44:39 +05:30
d4ecf97436
Correctly set -Xopt-in=kotlin.RequiresOptIn on all modules
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-31 15:06:36 +05:30
49d9ceb73a
app: cleanups
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-31 15:06:18 +05:30
Aditya Wasan
7c8cbc4b3f
src: make dataSource non nullable
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 14:58:09 +05:30
Aditya Wasan
ff4a2a751f
src: fix is_saved logic
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-31 14:46:29 +05:30
Aditya Wasan
6fdf1d0ca0
src(databse,buildSrc): remove kotlinReflect and opt into ExperimentalStdlibApi
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-30 12:51:17 +05:30
Aditya Wasan
8303159abf
src(api): use moshi-metadta-reflect
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-30 12:51:16 +05:30
Aditya Wasan
0a6371b159
Revert "Revert "all: switch to moshi-kotlin and fix tests""
...
This reverts commit 602d11de35180d72fae9472b280d08af460d940f.
2021-01-30 12:51:16 +05:30
c835a59cbf
proguard(app): disable ProGuard inlining optimisations
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:16 +05:30
32bfdde04e
Revert "all: switch to moshi-kotlin and fix tests"
...
This reverts commit da25dd2ed9bea50691b889e093ff896fea598b1a.
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:15 +05:30
Aditya Wasan
f9fcb089a1
src: remove cache and simplify db logic
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-30 12:51:15 +05:30
Aditya Wasan
3bcdcbdac7
Add LobstersRepo to handle DB operations
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-30 12:51:15 +05:30
4f9d0c09ef
Make is_saved nullable
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:14 +05:30
Aditya Wasan
ab3f112981
Use boolean for is_saved field
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2021-01-30 12:51:14 +05:30
740d9e432a
all: switch to moshi-kotlin and fix tests
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:14 +05:30
bca96ae215
app: switch to SQLDelight version of LobstersPost
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:51:13 +05:30
b18de72bdd
all: move model classes to database, rename model to api
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:50:09 +05:30
Aditya Wasan
62d7590501
Add tests for SQLDelight database
...
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:50:08 +05:30
Aditya Wasan
f3b02e8fc2
database: add Post model
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:50:08 +05:30
f17becff10
app: remove Room
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:50:07 +05:30
042b8f60d5
database: generate skeleton project
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-30 12:49:43 +05:30
bors[bot]
2dfcc4de8f
Merge #99
...
99: Tweak alignment and fixup build nits r=msfjarvis a=msfjarvis
bors r+
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 08:17:44 +00:00
33b238c646
LobstersItem: extract hard-coded submitter text
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:45:13 +05:30
a7bd050013
LobstersItem: use existing BASE_URL field
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:42:54 +05:30
5ab5d1ece7
LobstersItem: fix submitter name alignment with avatar
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:41:49 +05:30
07930d416d
build(app): remove kotlinCompilerVersion
...
It is deprecated now
'ComposeOptions.kotlinCompilerVersion is deprecated. Compose now uses the kotlin compiler defined in your buildscript.'
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 13:38:30 +05:30
929816c342
Revert "gradle: disable problematic flag"
...
Fixed in AGP 7.0.0-alpha05
This reverts commit 6b85bc51de
2021-01-28 13:26:56 +05:30
bors[bot]
5cee5ad5d3
Merge #98
...
98: Dependency updates r=msfjarvis a=msfjarvis
bors r+
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 06:35:31 +00:00
9d2a0acfcf
build: upgrade Room
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-28 12:04:14 +05:30
